Gollum@feddit.de to Programmer Humor@programming.dev · 8 months agoMe after I got firedfeddit.deimagemessage-square49fedilinkarrow-up180arrow-down11
arrow-up179arrow-down1imageMe after I got firedfeddit.deGollum@feddit.de to Programmer Humor@programming.dev · 8 months agomessage-square49fedilink
minus-squarePrettyFlyForAFatGuy@lemmy.mllinkfedilinkarrow-up0arrow-down1·8 months agoyou’d be surprised what slips through review
minus-squaresunbeam60@lemmy.onelinkfedilinkarrow-up0·8 months agoYeah but even a single automated test would catch it and reject the PR. You just need a single test.
minus-squarefrezik@midwest.sociallinkfedilinkarrow-up1·8 months agoNo, you can’t assume that. The probability of hitting the condition each time is low. If there aren’t very many calls that hit this, it could easily slip through. Especially on 64-bit int platforms.
you’d be surprised what slips through review
Yeah but even a single automated test would catch it and reject the PR. You just need a single test.
No, you can’t assume that. The probability of hitting the condition each time is low. If there aren’t very many calls that hit this, it could easily slip through. Especially on 64-bit int platforms.